Encore tweaks! #8035
Closed
Encore tweaks! #8035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 13, 2017
|
|
||
| Encore | ||
| // ... | ||
| .addEntry('app', './assets/js/main.js') |
There was a problem hiding this comment.
it's on the next line, and JavaScript will work just fine here 😛
But don't leave a trailing comma for better diff readability!, oh God no, we can't have that!! the Angels will the weep the blood of innocent, the sky will fall down like ashes, the seas will boil, the land will be engulfed with hordes of flies, chaos will rule the land for a 1000 years, nothing will ever grow anymore, all is dead. And.... ahhh, the compiler will fail to work 😑 JavaScript - forgives a missing semi-colon (when there is a space), but chokes on a trailing comma (because accepting that would be blasphemy).
There was a problem hiding this comment.
I am pretty sure it wasn't there when I commented. :)
weaverryan
added a commit
that referenced
this pull request
Jun 13, 2017
This PR was squashed before being merged into the 3.3 branch (closes #8035). Discussion ---------- Encore tweaks! Thanks to @bocharsky-bw! Commits ------- 9f64435 Encore tweaks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @bocharsky-bw!